[MINOR] Fix flaky test testGetHostIp#141
Merged
roryqi merged 1 commit intoapache:masterfrom Aug 8, 2022
Merged
Conversation
roryqi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
============================================
+ Coverage 57.18% 57.21% +0.03%
Complexity 1201 1201
============================================
Files 150 150
Lines 8179 8185 +6
Branches 773 773
============================================
+ Hits 4677 4683 +6
Misses 3256 3256
Partials 246 246
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Contributor
|
Thanks @izchen , wait for GA. |
roryqi
approved these changes
Aug 8, 2022
Contributor
Author
|
Thanks for your review, @jerqi ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Do not use
InetAddress.getLocalHost().getHostAddress()in test because it is indeterminate. The return value may be different on a multi-NIC machine or on different system.Why are the changes needed?
In addition to 127.0.0.1, the loopback address 127.0.1.1 can also be returned, which happens on Debian.This will make UT fail.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.